On Thu, Mar 03, 2022 at 01:41:13PM +0100, Robert Marko wrote: > On Wed, Mar 2, 2022 at 10:39 PM Rob Herring <robh@xxxxxxxxxx> wrote: > > > > On Wed, Mar 02, 2022 at 08:47:32AM +0000, Lee Jones wrote: > > > On Mon, 31 Jan 2022, Robert Marko wrote: > > > > > > > Add binding documents for the Delta TN48M CPLD drivers. > > > > > > > > Signed-off-by: Robert Marko <robert.marko@xxxxxxxxxx> > > > > > > This is missing a DT review. > > > > How about this one[1]? > > > > Rob > > > > [1] https://lore.kernel.org/all/20210719225906.GA2769608@xxxxxxxxxxxxxxxxxx/ > > Hi Rob, > Thanks for reaching out. > > As you can see the bindings have evolved since v6, > GPIO driver now only uses 2 distinct compatibles. Fundamentally, it hasn't really changed. There's 2 main issues. First, I don't see the need for any child nodes. This would be sufficient: cpld@41 { compatible = "delta,tn48m-cpld"; reg = <0x41>; #reset-cells = <1>; #gpio-cells = <2>; gpio-controller; }; You only need child nodes if the sub-blocks have their own resources or are widely reused in different configurations. The 2nd issue is whether GPIOs are even GPIOs at all. I don't recall that Linus ever agreed. Both issues kind of boil down to is there even more that 1 variation of this h/w where you have differing connections? AFAICT, Delta tn48m is a pretty specific device and I would guess something implemented in a CPLD is likely to change on every board design. At least that's my experience with 'board level logic'. Rob
