On Fri Mar 04 2022, Divya Koppera wrote:
> Add support for 1588 in LAN8814 phy driver.
> It supports 1-step and 2-step timestamping.
>
> Co-developed-by: Horatiu Vultur <horatiu.vultur@xxxxxxxxxxxxx>
> Signed-off-by: Divya Koppera <Divya.Koppera@xxxxxxxxxxxxx>
> ---
> drivers/net/phy/micrel.c | 1088 +++++++++++++++++++++++++++++++++++++-
> 1 file changed, 1066 insertions(+), 22 deletions(-)
[snip]
> +static bool is_sync(struct sk_buff *skb, int type)
> +{
> + struct ptp_header *hdr;
> +
> + hdr = ptp_parse_header(skb, type);
> + if (!hdr)
> + return false;
> +
> + return ((ptp_get_msgtype(hdr, type) & 0xf) == 0);
The '& 0xf' is already performed by ptp_get_msgtype() and you can use '==
PTP_MSGTYPE_SYNC' instead of 0.
Second, this seems like the second driver to use is_sync(). The other
one is dp83640. Richard, should it be moved to ptp classify?
Thanks,
Kurt
Attachment:
signature.asc
Description: PGP signature
