Hi Krzysztof: Thank you for your comment and it'll be addressed. Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxxxxx> 於 2022年3月3日 週四 下午6:38寫道： > > On 03/03/2022 09:31, Tyrone Ting wrote: > > From: Tyrone Ting <kfting@xxxxxxxxxxx> > > > > Add compatible and nuvoton,sys-mgr description for NPCM i2c module. > > > > Signed-off-by: Tyrone Ting <kfting@xxxxxxxxxxx> > > Signed-off-by: Tali Perry <tali.perry1@xxxxxxxxx> > > --- > > .../bindings/i2c/nuvoton,npcm7xx-i2c.yaml | 26 +++++++++++++++---- > > 1 file changed, 21 insertions(+), 5 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/i2c/nuvoton,npcm7xx-i2c.yaml b/Documentation/devicetree/bindings/i2c/nuvoton,npcm7xx-i2c.yaml > > index 128444942aec..37976ddcf406 100644 > > --- a/Documentation/devicetree/bindings/i2c/nuvoton,npcm7xx-i2c.yaml > > +++ b/Documentation/devicetree/bindings/i2c/nuvoton,npcm7xx-i2c.yaml > > @@ -7,17 +7,18 @@ $schema: http://devicetree.org/meta-schemas/core.yaml# > > title: nuvoton NPCM7XX I2C Controller Device Tree Bindings > > > > description: | > > - The NPCM750x includes sixteen I2C bus controllers. All Controllers support > > - both master and slave mode. Each controller can switch between master and slave > > - at run time (i.e. IPMB mode). Each controller has two 16 byte HW FIFO for TX and > > - RX. > > + I2C bus controllers of the NPCM series support both master and > > + slave mode. Each controller can switch between master and slave at run time > > + (i.e. IPMB mode). HW FIFO for TX and RX are supported. > > > > maintainers: > > - Tali Perry <tali.perry1@xxxxxxxxx> > > > > properties: > > compatible: > > - const: nuvoton,npcm750-i2c > > + enum: > > + - nuvoton,npcm750-i2c > > + - nuvoton,npcm845-i2c > > > > reg: > > maxItems: 1 > > @@ -36,6 +37,10 @@ properties: > > default: 100000 > > enum: [100000, 400000, 1000000] > > > > + nuvoton,sys-mgr: > > + $ref: "/schemas/types.yaml#/definitions/phandle" > > + description: The phandle of system manager register node. > > + > > required: > > - compatible > > - reg > > @@ -44,6 +49,16 @@ required: > > > > allOf: > > - $ref: /schemas/i2c/i2c-controller.yaml# > > + - if: > > + properties: > > + compatible: > > + contains: > > + const: > > + - nuvoton,npcm845-i2c > > This should be one line in const (not an enum). > > Rest looks good to me. > > Best regards, > Krzysztof Best regards, Tyrone
