On 04/03/2022 11:57, Alim Akhtar wrote: > > >> -----Original Message----- >> From: Krzysztof Kozlowski [mailto:krzysztof.kozlowski@xxxxxxxxxxxxx] >> Sent: Friday, February 25, 2022 9:07 PM >> To: Daniel Lezcano <daniel.lezcano@xxxxxxxxxx>; Thomas Gleixner >> <tglx@xxxxxxxxxxxxx>; Rob Herring <robh+dt@xxxxxxxxxx>; Krzysztof Kozlowski >> <krzysztof.kozlowski@xxxxxxxxxxxxx>; Alim Akhtar >> <alim.akhtar@xxxxxxxxxxx>; linux-kernel@xxxxxxxxxxxxxxx; >> devicetree@xxxxxxxxxxxxxxx; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; linux- >> samsung-soc@xxxxxxxxxxxxxxx >> Subject: [PATCH 3/3] arm64: dts: exynos: add a specific compatible to MCT >> >> One compatible is used for the Multi-Core Timer on most of the Samsung > Exynos >> SoCs, which is correct but not specific enough. These MCT blocks have > different >> number of interrupts, so add a second specific compatible to Exynos5433 and >> Exynos850. >> >> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxxxxx> >> --- >> arch/arm64/boot/dts/exynos/exynos5433.dtsi | 3 ++- >> arch/arm64/boot/dts/exynos/exynos850.dtsi | 3 ++- >> 2 files changed, 4 insertions(+), 2 deletions(-) >> >> diff --git a/arch/arm64/boot/dts/exynos/exynos5433.dtsi >> b/arch/arm64/boot/dts/exynos/exynos5433.dtsi >> index 661567d2dd7a..017ccc2f4650 100644 >> --- a/arch/arm64/boot/dts/exynos/exynos5433.dtsi >> +++ b/arch/arm64/boot/dts/exynos/exynos5433.dtsi >> @@ -806,7 +806,8 @@ tmu_isp: tmu@1007c000 { >> }; >> >> timer@101c0000 { >> - compatible = "samsung,exynos4210-mct"; >> + compatible = "samsung,exynos5433-mct", >> + "samsung,exynos4210-mct"; > > Just a though, do we still need to keep Samsung,exyno4210-mct compatible? > In anyway: > > Reviewed-by: Alim Akhtar <alim.akhtar@xxxxxxxxxxx> Yes, otherwise we break all other projects using DTS from Linux kernel. Also keeping it allows to apply DTS patches independently without breaking bisectability. Best regards, Krzysztof
