On 04/03/2022 09:42, Zong Li wrote: > Add dma-channels property, then we can determine how many channels there > by device tree, rather than statically defining it in PDMA driver. > In addition, we also modify the compatible for PDMA versioning scheme. > > Signed-off-by: Zong Li <zong.li@xxxxxxxxxx> > Suggested-by: Palmer Dabbelt <palmer@xxxxxxxxxxxx> > Reviewed-by: Rob Herring <robh@xxxxxxxxxx> > Reviewed-by: Palmer Dabbelt <palmer@xxxxxxxxxxxx> > Acked-by: Palmer Dabbelt <palmer@xxxxxxxxxxxx> > --- > .../bindings/dma/sifive,fu540-c000-pdma.yaml | 19 +++++++++++++++++-- > 1 file changed, 17 insertions(+), 2 deletions(-) > Can you add subystem/driver prefix to the subject? In current form it looks generic, but it is actually specific, so: dt-bindings: dma-engine: sifive,fu540: Best regards, Krzysztof