On Fri, 4 Mar 2022, at 08:05, Joel Stanley wrote: > On Thu, 3 Mar 2022 at 19:34, Rob Herring <robh@xxxxxxxxxx> wrote: >> >> On Wed, Mar 2, 2022 at 12:01 PM Rob Herring <robh@xxxxxxxxxx> wrote: >> > >> > On Wed, Mar 02, 2022 at 03:40:56PM +1030, Joel Stanley wrote: >> > > Convert the bindings to yaml and add the ast2600 compatible string. >> > > >> > > Signed-off-by: Joel Stanley <joel@xxxxxxxxx> >> > > --- >> > > .../devicetree/bindings/gpu/aspeed,gfx.yaml | 69 +++++++++++++++++++ >> > > .../devicetree/bindings/gpu/aspeed-gfx.txt | 41 ----------- >> > > 2 files changed, 69 insertions(+), 41 deletions(-) >> > > create mode 100644 Documentation/devicetree/bindings/gpu/aspeed,gfx.yaml >> > > delete mode 100644 Documentation/devicetree/bindings/gpu/aspeed-gfx.txt >> > >> > Applied, thanks. >> >> Uggg, now dropped... >> >> What's Documentation/devicetree/bindings/mfd/aspeed-gfx.txt and also >> the example in Documentation/devicetree/bindings/pinctrl/aspeed,ast2500-pinctrl.yaml? >> Please sort those out. > > I think the aspeed-gfx.txt can be deleted. And the example in the > pinctrl bindings needs to be updated with the required properties. > > Andrew, can you clarify what's going on with those other files? Looks like you'll just need to paste your example from aspeed,gfx.yaml into the pinctrl yamls to replace the existing gfx nodes. Andrew