On Thu, Mar 03, 2022 at 07:44:38AM -0600, Rob Herring wrote:
> On Wed, 02 Mar 2022 17:26:12 -0600, Chris Morgan wrote:
> > From: Chris Morgan <macromorgan@xxxxxxxxxxx>
> >
> > Convert the rk808 bindings into yaml format. clock-output-names varies
> > in maxItems depending on whether or not the clock-cells is 0 or 1. For
> > the rk805, rk809, and rk817. This preserves behavior with the existing
> > driver handling setting the clock for these specific PMICs. When this
> > driver is corrected and the devicetrees updated this logic can be
> > removed (since the rk805, rk808, and rk817 only have one actual clock).
> >
> > Signed-off-by: Chris Morgan <macromorgan@xxxxxxxxxxx>
> > ---
> > .../devicetree/bindings/mfd/rk808.txt | 465 ------------------
> > .../bindings/mfd/rockchip,rk805.yaml | 219 +++++++++
> > .../bindings/mfd/rockchip,rk808.yaml | 257 ++++++++++
> > .../bindings/mfd/rockchip,rk809.yaml | 284 +++++++++++
> > .../bindings/mfd/rockchip,rk817.yaml | 330 +++++++++++++
> > .../bindings/mfd/rockchip,rk818.yaml | 282 +++++++++++
> > 6 files changed, 1372 insertions(+), 465 deletions(-)
> > delete mode 100644 Documentation/devicetree/bindings/mfd/rk808.txt
> > create mode 100644 Documentation/devicetree/bindings/mfd/rockchip,rk805.yaml
> > create mode 100644 Documentation/devicetree/bindings/mfd/rockchip,rk808.yaml
> > create mode 100644 Documentation/devicetree/bindings/mfd/rockchip,rk809.yaml
> > create mode 100644 Documentation/devicetree/bindings/mfd/rockchip,rk817.yaml
> > create mode 100644 Documentation/devicetree/bindings/mfd/rockchip,rk818.yaml
> >
>
> My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
> on your patch (DT_CHECKER_FLAGS is new in v5.13):
>
> yamllint warnings/errors:
>
> dtschema/dtc warnings/errors:
> /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/mfd/rockchip,rk818.example.dt.yaml: pmic@1c: regulators: Unevaluated properties are not allowed ('DCDC_BOOST' was unexpected)
> From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/mfd/rockchip,rk818.yaml
>
> doc reference errors (make refcheckdocs):
> Documentation/devicetree/bindings/pinctrl/pinctrl-rk805.txt: Documentation/devicetree/bindings/mfd/rk808.txt
>
> See https://patchwork.ozlabs.org/patch/1600127
>
> This check can fail if there are any dependencies. The base for a patch
> series is generally the most recent rc1.
>
> If you already ran 'make dt_binding_check' and didn't see the above
> error(s), then make sure 'yamllint' is installed and dt-schema is up to
> date:
>
> pip3 install dtschema --upgrade
>
> Please check and re-submit.
>
My apologies, but yes I did in fact have an older version of the
dtschema. I upgraded and it warned me of this issue, which I will
fix and resubmit. Sorry.
Chris
