Hi Ezequiel, On 08/09/14 01:12, Ezequiel Garcia wrote: > Hi Greg, > > On 07 Sep 10:14 PM, Greg Ungerer wrote: >> Hi Ezequiel, >> >> On 06/09/14 22:06, Ezequiel Garcia wrote: >>> Hi Greg, >>> >>> (Ccing mvebu guys, full discussion here: http://www.spinics.net/lists/devicetree/msg47806.html) >>> >>> On 05 Sep 11:11 PM, Greg Ungerer wrote: >>>> On 05/09/14 17:36, Geert Uytterhoeven wrote: >>>>> No, the other way around (from most-specific to least-specific): >>>>> >>>>> compatible = "marvell,armada-spi", "marvell,orion-spi" >>>>> >>>>> So the Armada version is used if available, and the Orion version >>>>> is used as a fallback. >>> Since you are doing another spin, please split this in two patches. >>> The driver and devicetree binding documentation should be in one patch, >>> and the devicetree .dtsi change in another patch. >>> >>> By following Geert's request about the compatible, you make sure both >>> patches can be merged through different maintainers, and that an old devicetree >>> blob can be used safely. >> >> Sure, yes, I would prefer that too. I didn't do it for this because >> checkpatch >> complained for the spi-orion.c change in its own: >> >> WARNING: DT compatible string "marvell,armada-spi" appears un-documented -- >> check ./Documentation/devicetree/bindings/ >> #170: FILE: drivers/spi/spi-orion.c:412: >> + { .compatible = "marvell,armada-spi", .data = &armada_spi_dev_data, }, >> >> But I am happy to ignore that :-) >> > > If you split in two patches like this: > > Patch #1: "spi: orion: Add a new foo feature" > > .../devicetree/bindings/spi/spi-orion.txt | 2 +- > drivers/spi/spi-orion.c | 116 +++++++++++++++++---- > > Patch #2: "ARM: mvebu: Add new compatible string for SPI" > > arch/arm/boot/dts/armada-370-xp.dtsi | 4 +- > > Then checkpatch shouldn't complain. As you can see, it makes more sense like > this. The change to the devicetree binding in the driver and properly > documented, but the devicetree files per-se, get modified in another patch. Ok, I see. Thanks. Regards Greg -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
