Re: [PATCH v8 2/2] clocksource: Add Intel Keem Bay timer support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 02/03/2022 14:53, Andy Shevchenko wrote:
On Tue, Mar 01, 2022 at 10:09:06PM +0100, Daniel Lezcano wrote:
On 22/02/2022 10:56, shruthi.sanil@xxxxxxxxx wrote:

+		/* Clear interrupt for periodic timer*/

nit: comment format is:

/*
  * my comment
  */

One line comment format is usually for the network subsystem

Huh?
Any pointers to the documentation, please?

https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/coding-style.rst#n598

Well actually it is for multi line, so I may have confused with these one line comments.

On the other hand having one line comment telling what does the function right after is not really useful. The function names are self-explanatory.

+		keembay_timer_clear_pending_int(tim_base);
+	} else {
+		/* Disable the timer for one shot timer */

comment format

+		keembay_timer_disable(tim_base);
+	}



--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog



[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux