On Fri, 5 Sep 2014, Nishanth Menon wrote: > + if (!palmas->wakeirq) > + goto no_wake_irq; > + > + ret = devm_request_irq(palmas->dev, palmas->wakeirq, > + palmas_wake_irq, > + IRQF_ONESHOT | pdata->irq_flags, Why is this marked IRQF_ONESHOT? > + dev_name(palmas->dev), > + &palmas); > + if (ret < 0) > + goto err_i2c; Why err and not doing the obvious clearing of palmas->wakeirq and keep at least the i2c functional? Thanks, tglx -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
