On 2/28/22 15:24, Rob Herring wrote: > On Tue, Feb 1, 2022 at 12:14 PM <frowand.list@xxxxxxxxx> wrote: >> >> From: Frank Rowand <frank.rowand@xxxxxxxx> >> >> If unittest detects a problem it will print a warning or error message >> to the console. Unittest also triggers warning and error messages from >> other kernel code as a result of intentionally bad unittest data. This >> has led to confusion as to whether the triggered messages are an >> expected result of a test or whether there is a real problem that is >> independent of unittest. >> >> EXPECT messages were added to unittest to report each triggered message >> that is expected, resulting in verbose console output. >> >> scripts/dtc/of_unittest is a new program that processes the EXPECT >> messages to determine whether the triggered messages occurred and >> also removes the excess verbosity of the EXPECT messages. More >> information is available from 'scripts/dtc/of_unittest_expect --help'. >> >> Signed-off-by: Frank Rowand <frank.rowand@xxxxxxxx> >> --- >> permissions for scripts/dtc/of_unittest should be 770 > > Why? 755 is what the patch says and what most/all executables in the kernel are. I based that on the permissions of other executables in scripts/dtc/ I do like 755 better, thanks for pointing out the wider population of executables in the kernel. -Frank > > Rob > >> >> I will reply to this message with the usage message from >> 'scripts/dtc/of_unittest_expect --help'. >> >> I will also reply with examples of raw and processed console logs. >> >> Documentation/devicetree/of_unittest.rst | 27 +- >> scripts/dtc/of_unittest_expect | 408 +++++++++++++++++++++++ >> 2 files changed, 432 insertions(+), 3 deletions(-) >> create mode 100755 scripts/dtc/of_unittest_expect
