On Mon, Feb 28, 2022 at 04:50:27PM +0100, Vincent Whitchurch wrote:
> On Wed, Feb 23, 2022 at 02:23:16PM +0000, Mark Brown wrote:
> > That's not going to stop anyone. We should at the very least be
> > printing very loud warnings if anyone tries to intantiate this.
> I can add a warning. Maybe something like this, following the style of
> kernel/trace/trace.c?
> pr_warn("**********************************************************\n");
> pr_warn("** NOTICE NOTICE NOTICE NOTICE NOTICE NOTICE NOTICE **\n");
> pr_warn("** **\n");
> pr_warn("** regulator-virtual-consumer is only for testing and **\n");
> pr_warn("** debugging. Do not use it in a production kernel. **\n");
> pr_warn("** **\n");
> pr_warn("** NOTICE NOTICE NOTICE NOTICE NOTICE NOTICE NOTICE **\n");
> pr_warn("**********************************************************\n");
Something along those lines would do it, yes.
> > > + if (!reg_id)
> > > + reg_id = "default";
> > > +
> > Oh?
> As you know, this results in looking for the regulator phandle in a
> property named "default-supply". I wasn't sure what supply name to use
> for this virtual client. Getting the name from another property seemed
> unnecessary. Would you prefer that, or would you suggest some other
> name than "default"?
I'd suggest adding a comment.
Attachment:
signature.asc
Description: PGP signature
