On 2022-02-28 12:43, Kuldeep Singh wrote:
Add missing minItems property to clocks in ARM pl022 bindings.
This also helps in resolving below dtc warnings:
arch/arm64/boot/dts/amd/amd-overdrive.dt.yaml: spi@e1020000: clocks: [[4]] is too short
From schema: Documentation/devicetree/bindings/spi/spi-pl022.yaml
arch/arm64/boot/dts/amd/amd-overdrive.dt.yaml: spi@e1020000: clock-names: ['apb_pclk'] is too short
From schema: Documentation/devicetree/bindings/spi/spi-pl022.yaml
Who says that minItems is missing? Looking at the PL022 TRM[1] it seems
clear that SSPCLK is pretty fundamental to useful operation. If that DT
ever worked, it must be that the same clock is wired to both inputs, and
the fact that that's how the neighbouring PL011 is described is strongly
suggestive.
If the point of schema is to find errors in DTs, doesn't it make more
sense to fix the DTs than to weaken the schema just to shut it up?
Of course in this particular case there's also the question of whether
the most humane way to "fix" the Seattle DTs is to simply delete them,
but that's orthogonal.
Robin.
[1] https://developer.arm.com/documentation/ddi0194/h/?lang=en
Signed-off-by: Kuldeep Singh <singh.kuldeep87k@xxxxxxxxx>
---
Documentation/devicetree/bindings/spi/spi-pl022.yaml | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/spi/spi-pl022.yaml b/Documentation/devicetree/bindings/spi/spi-pl022.yaml
index 6d633728fc2b..7d36e15db5b3 100644
--- a/Documentation/devicetree/bindings/spi/spi-pl022.yaml
+++ b/Documentation/devicetree/bindings/spi/spi-pl022.yaml
@@ -34,6 +34,7 @@ properties:
maxItems: 1
clocks:
+ minItems: 1
maxItems: 2
clock-names:
