Hi Sakari, Sakari Ailus <sakari.ailus@xxxxxx> writes: >> >> + // access the sensor only if it's powered up > > /* This is the preferred comment style */ I keep forgetting about this. Maybe because most other code I work with (not drivers/media) has already switched to // (single-line) comments. > The OF folks have shunned to the use of the iterative varants as that can > often lead to complicated parsing of the endpoints. As obtaining the > endpoint based on port and endpoint IDs works well in all cases I've > suggested people to use that. But as the backend, at least currently, uses > iterative functions, they're unlikely to disappear in the future. I understand I should continue using fwnode_graph_get_endpoint_by_id(), right? Thanks. -- Krzysztof "Chris" Hałasa Sieć Badawcza Łukasiewicz Przemysłowy Instytut Automatyki i Pomiarów PIAP Al. Jerozolimskie 202, 02-486 Warszawa