Hi Marek, On Mon, 2022-02-28 at 01:45 +0100, Marek Vasut wrote: > Add compatible string for i.MX8MP LCDIF variant. This is called LCDIFv3 > and is completely different from the LCDIFv3 found in i.MX23 in that it In i.MX23 reference manual, there is no LCDIFv3 found, but only LCDIF. > has a completely scrambled register layout compared to all previous LCDIF It looks like no single register of i.MX8MP LCDIFv3 overlaps with registers in other i.MX2x/6x/7x/8x LCDIFs. The LCDIFv3 block diagram is totally different from the LCDIF block diagram, according to the SoC reference manuals. LCDIFv3 supports SHADOW_EN bit to update horizontal and vertical size of graphic, position of graphic on the panel, address of graphic in memory and color formats or color palettes, which is not supported by LCDIF and impacts display driver control mechanism considerably. LCDIF supports DOTCLK interface, MPU interface and VSYNC interface, while LCDIFv3 only supports parallel output as a counterpart of the DOTCLK interface. Generally speaking, LCDIFv3 is just a new display IP which happens to have the word 'LCDIF' in its name. Although both of LCDIFv3 and LCDIF are display controllers for scanning out frames onto display devices, I don't think they are in one family. So, LCDIFv3 deserves a new separate dt-binding, IMO. > variants. The new LCDIFv3 also supports 36bit address space. However, > except for the complete bit reshuffling, this is still LCDIF and it still > works like one. > > Signed-off-by: Marek Vasut <marex@xxxxxxx> > Cc: Alexander Stein <alexander.stein@xxxxxxxxxxxxxxx> > Cc: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx> > Cc: Lucas Stach <l.stach@xxxxxxxxxxxxxx> > Cc: Peng Fan <peng.fan@xxxxxxx> > Cc: Rob Herring <robh+dt@xxxxxxxxxx> > Cc: Robby Cai <robby.cai@xxxxxxx> > Cc: Sam Ravnborg <sam@xxxxxxxxxxxx> > Cc: Stefan Agner <stefan@xxxxxxxx> > Cc: devicetree@xxxxxxxxxxxxxxx > --- > Documentation/devicetree/bindings/display/fsl,lcdif.yaml | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/devicetree/bindings/display/fsl,lcdif.yaml b/Documentation/devicetree/bindings/display/fsl,lcdif.yaml > index 900a56cae80e6..9831ab53a053d 100644 > --- a/Documentation/devicetree/bindings/display/fsl,lcdif.yaml > +++ b/Documentation/devicetree/bindings/display/fsl,lcdif.yaml > @@ -28,6 +28,7 @@ properties: > - fsl,imx7d-lcdif > - fsl,imx8mm-lcdif > - fsl,imx8mn-lcdif > + - fsl,imx8mp-lcdif Even if LCDIFv3 is covered by this dt-binding(which is obviously not the case), 'fsl,imx8mp-lcdif' should be after 'fsl,imx6x-lcdif' as an enum, otherwise LCDIFv3 is compatible to LCDIF. Regards, Liu Ying > - fsl,imx8mq-lcdif > - const: fsl,imx6sx-lcdif >
