On Friday 05 September 2014 15:14:33 Stanimir Varbanov wrote: > + VADC_CHAN(LR_MUX1_BAT_THERM, 0) /* 0x30 */ > + VADC_CHAN(LR_MUX2_BAT_ID, 0) > + VADC_CHAN(LR_MUX3_XO_THERM, 0) > + VADC_CHAN(LR_MUX4_AMUX_THM1, 0) > + VADC_CHAN(LR_MUX5_AMUX_THM2, 0) > + VADC_CHAN(LR_MUX6_AMUX_THM3, 0) > + VADC_CHAN(LR_MUX7_HW_ID, 0) > + VADC_CHAN(LR_MUX8_AMUX_THM4, 0) > + VADC_CHAN(LR_MUX9_AMUX_THM5, 0) > + VADC_CHAN(AMUX_PU1, 0) > + VADC_CHAN(AMUX_PU2, 0) > + VADC_CHAN(LR_MUX3_BUF_XO_THERM_BUF, 0) /* 0x3c */ > + > + VADC_CHAN(LR_MUX1_PU1_BAT_THERM, 0) /* 0x70 */ > + VADC_CHAN(LR_MUX2_PU1_BAT_ID, 0) > + VADC_CHAN(LR_MUX3_PU1_XO_THERM, 0) > + VADC_CHAN(LR_MUX4_PU1_AMUX_THM1, 0) > + VADC_CHAN(LR_MUX5_PU1_AMUX_THM2, 0) > + VADC_CHAN(LR_MUX6_PU1_AMUX_THM3, 0) > + VADC_CHAN(LR_MUX7_PU1_AMUX_HW_ID, 0) > + VADC_CHAN(LR_MUX8_PU1_AMUX_THM4, 0) > + VADC_CHAN(LR_MUX9_PU1_AMUX_THM5, 0) > + VADC_CHAN(LR_MUX10_PU1_AMUX_USB_ID, 0) /* 0x79 */ > + VADC_CHAN(LR_MUX3_BUF_PU1_XO_THERM_BUF, 0) /* 0x7c */ > These numbers all look hardware specific, so why put macros into the device tree rather than using them directly? If you want to make up your own macro namespace, I would suggest using consecutive numbers and turning the above into ... [LR_MUX3_BUF_XO_THERM_BUF] = VADC_CHAN(0x3c, 0), [LR_MUX1_PU1_BAT_THERM] = VADC_CHAN(0x70, 0), [LR_MUX1_PU1_BAT_ID] = VADC_CHAN(0x71, 0), ... but I don't see that really improving the DT, since you then need to look up the values in the header rather than the data sheet. Arnd -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
