Hi Dmitry, Thanks for your review comments. On Thu, 24 Feb 2022 at 20:22, Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx> wrote: > > On Thu, 24 Feb 2022 at 15:33, Bhupesh Sharma <bhupesh.sharma@xxxxxxxxxx> wrote: > > > > Since '#clock-cells' is not a required property for several > > QCoM boards supporting qmp-phy(s) (for e.g. sm8150, sm8250 or sm8350 SoC > > based boards), mark it as an optional property instead. > > I believe the description is not correct. the clock-cells should not > be used at all, so it should be removed from the root node. Hmm.. 'clock-cells' is still used for describing qmp phy pcie nodes for certain devices like 'msm8996.dtsi'. I am not sure if removing it would impact existing dts files. But let me try cleaning them up in v2. > Also we should describe phy@ properties. Sure, I will add them in v2. Regards, Bhupesh > > > > This fixes the following '$ make dtbs_check' warning(s): > > > > sm8350-microsoft-surface-duo2.dt.yaml: phy@1d87000: > > '#clock-cells' is a required property > > > > Cc: Bjorn Andersson <bjorn.andersson@xxxxxxxxxx> > > Cc: Vinod Koul <vkoul@xxxxxxxxxx> > > Cc: Rob Herring <robh+dt@xxxxxxxxxx> > > Signed-off-by: Bhupesh Sharma <bhupesh.sharma@xxxxxxxxxx> > > --- > > Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml | 1 - > > 1 file changed, 1 deletion(-) > > > > diff --git a/Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml > > index 9e0f60e682c4..746a929c63bb 100644 > > --- a/Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml > > +++ b/Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml > > @@ -115,7 +115,6 @@ patternProperties: > > required: > > - compatible > > - reg > > - - "#clock-cells" > > - "#address-cells" > > - "#size-cells" > > - ranges > > -- > > 2.35.1 > > > > > -- > With best wishes > Dmitry
