Re: [PATCH] ARM: dts: qcom: Add chosen node information for SDX65.

[Rohit Agarwal <quic_rohiagar@xxxxxxxxxxx>]

On 2/25/2022 1:14 AM, Bjorn Andersson wrote:
> On Fri 11 Feb 04:20 CST 2022, Rohit Agarwal wrote:
>
> > Add chosen node in the base dtsi file of SDX65.
> While this happens to be the same on most boards, it is still a
> board-specific decision which UART is the debug uart, or if there is one
> at all...
>
> So this property should remain in the dts.
>
> Thanks,
> Bjorn

Without the chosen node in base dtsi, the device is not booting up.
Can we have an empty chosen node in the base dtsi and the board-specific 
details
updated in the respective dts file. The device boots up with this.

Thanks,
Rohit

> > Signed-off-by: Rohit Agarwal <quic_rohiagar@xxxxxxxxxxx>
> > ---
> >   arch/arm/boot/dts/qcom-sdx65-mtp.dts | 4 ----
> >   arch/arm/boot/dts/qcom-sdx65.dtsi    | 4 ++++
> >   2 files changed, 4 insertions(+), 4 deletions(-)
> >
> > diff --git a/arch/arm/boot/dts/qcom-sdx65-mtp.dts b/arch/arm/boot/dts/qcom-sdx65-mtp.dts
> > index 59457da..3a75c21 100644
> > --- a/arch/arm/boot/dts/qcom-sdx65-mtp.dts
> > +++ b/arch/arm/boot/dts/qcom-sdx65-mtp.dts
> > @@ -14,10 +14,6 @@
> >   	aliases {
> >   		serial0 = &blsp1_uart3;
> >   	};
> > -
> > -	chosen {
> > -		stdout-path = "serial0:115200n8";
> > -	};
> >   };
> >   
> >   &blsp1_uart3 {
> > diff --git a/arch/arm/boot/dts/qcom-sdx65.dtsi b/arch/arm/boot/dts/qcom-sdx65.dtsi
> > index 796641d..653df15 100644
> > --- a/arch/arm/boot/dts/qcom-sdx65.dtsi
> > +++ b/arch/arm/boot/dts/qcom-sdx65.dtsi
> > @@ -17,6 +17,10 @@
> >   	qcom,msm-id = <458 0x10000>, <483 0x10000>, <509 0x10000>;
> >   	interrupt-parent = <&intc>;
> >   
> > +	chosen {
> > +		stdout-path = "serial0:115200n8";
> > +	};
> > +
> >   	memory {
> >   		device_type = "memory";
> >   		reg = <0 0>;
> > --
> > 2.7.4