Re: [PATCH] dt-bindings: spi: delete unused required and adjust the item.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Feb 17, 2022 at 7:56 PM Li-hao Kuo <lhjeff911@xxxxxxxxx> wrote:
>
> delete unused required(clock-name)
> adjust position (interrupts)

Why? This seems like an unnecessary change.

Please write complete sentences that answer why this change is needed,
not what the change is. The diff describes what changed. In this case,
quoting the warning you are fixing is typical.

>
> Fixes: 3b8ab4da34 ("spi: Fix test error for sp7021")
>

There should not be a blank line here.

> Reported-by: Rob Herring <robh+dt@xxxxxxxxxx>
> Signed-off-by: Li-hao Kuo <lhjeff911@xxxxxxxxx>
> ---
>  Documentation/devicetree/bindings/spi/spi-sunplus-sp7021.yaml | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/spi/spi-sunplus-sp7021.yaml b/Documentation/devicetree/bindings/spi/spi-sunplus-sp7021.yaml
> index 298eac2..9df08d7 100644
> --- a/Documentation/devicetree/bindings/spi/spi-sunplus-sp7021.yaml
> +++ b/Documentation/devicetree/bindings/spi/spi-sunplus-sp7021.yaml
> @@ -47,10 +47,9 @@ required:
>    - compatible
>    - reg
>    - reg-names
> -  - interrupts
>    - interrupt-names
> +  - interrupts
>    - clocks
> -  - clocks-names
>    - resets
>    - pinctrl-names
>    - pinctrl-0
> --
> 2.7.4
>



[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux