On Thu, Feb 17, 2022 at 08:43:23AM +0100, Rafał Miłecki wrote:
> Hi Rob,
>
> On 17.02.2022 04:59, Rob Herring wrote:
> > On Wed, 16 Feb 2022 11:41:26 +0100, Rafał Miłecki wrote:
> > > From: Rafał Miłecki <rafal@xxxxxxxxxx>
> > >
> > > This helps validating DTS files.
> > >
> > > Signed-off-by: Rafał Miłecki <rafal@xxxxxxxxxx>
> > > ---
> > > .../bindings/mtd/partitions/brcm,trx.txt | 42 ---------------
> > > .../bindings/mtd/partitions/brcm,trx.yaml | 51 +++++++++++++++++++
> > > 2 files changed, 51 insertions(+), 42 deletions(-)
> > > delete mode 100644 Documentation/devicetree/bindings/mtd/partitions/brcm,trx.txt
> > > create mode 100644 Documentation/devicetree/bindings/mtd/partitions/brcm,trx.yaml
> > >
> >
> > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
> > on your patch (DT_CHECKER_FLAGS is new in v5.13):
> >
> > yamllint warnings/errors:
> >
> > dtschema/dtc warnings/errors:
> > /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/mtd/partitions/linksys,ns-partitions.example.dt.yaml: partition@200000: compatible:0: 'brcm,trx' was expected
> > From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/mtd/partitions/brcm,trx.yaml
> > /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/mtd/partitions/linksys,ns-partitions.example.dt.yaml: partition@200000: compatible: ['linksys,ns-firmware', 'brcm,trx'] is too long
> > From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/mtd/partitions/brcm,trx.yaml
>
> could you advise the best way to solve that?
You should move linksys,ns-firmware from linksys,ns-partitions.yaml to
this schema. Then linksys,ns-partitions.yaml just has:
"^partition@[0-9a-f]+$":
$ref: "partition.yaml#"
additionalProperties: true
That's not completely ideal because then undocumented properties are
allowed. To fix that, you'd need:
"^partition@[0-9a-f]+$":
oneOf:
- $ref: "partition.yaml#"
- $ref: "brcm,trx.yaml#"
unevaluatedProperties: false
I'm not 100% sure that will work.
Rob
