Re: [PATCH v5 4/5] PCI: qcom: Add interconnect support to 2.7.0/1.9.0 ops

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 23/02/2022 02:49, Bjorn Andersson wrote:
On Sat 18 Dec 06:10 PST 2021, Dmitry Baryshkov wrote:

Add optional interconnect support for the 2.7.0/1.9.0 hosts. Set the
bandwidth according to the values from the downstream driver.

Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx>
---
  drivers/pci/controller/dwc/pcie-qcom.c | 11 +++++++++++
  1 file changed, 11 insertions(+)

diff --git a/drivers/pci/controller/dwc/pcie-qcom.c b/drivers/pci/controller/dwc/pcie-qcom.c
index d8d400423a0a..55ac3caa6d7d 100644
--- a/drivers/pci/controller/dwc/pcie-qcom.c
+++ b/drivers/pci/controller/dwc/pcie-qcom.c
@@ -12,6 +12,7 @@
  #include <linux/crc8.h>
  #include <linux/delay.h>
  #include <linux/gpio/consumer.h>
+#include <linux/interconnect.h>
  #include <linux/interrupt.h>
  #include <linux/io.h>
  #include <linux/iopoll.h>
@@ -167,6 +168,7 @@ struct qcom_pcie_resources_2_7_0 {
  	struct clk *pipe_clk_src;
  	struct clk *phy_pipe_clk;
  	struct clk *ref_clk_src;
+	struct icc_path *path;

I think it's fair to assume that pretty much all platforms will have a
data path to reach the config registers and for the PCI to reach DDR.

So how about we place this in the common struct qcom_pcie instead?

Sounds logical. I'll think about it.


Regards,
Bjorn

  };
union qcom_pcie_resources {
@@ -1121,6 +1123,10 @@ static int qcom_pcie_get_resources_2_7_0(struct qcom_pcie *pcie)
  	if (IS_ERR(res->pci_reset))
  		return PTR_ERR(res->pci_reset);
+ res->path = devm_of_icc_get(dev, "pci");
+	if (IS_ERR(res->path))
+		return PTR_ERR(res->path);
+
  	res->supplies[0].supply = "vdda";
  	res->supplies[1].supply = "vddpe-3v3";
  	ret = devm_regulator_bulk_get(dev, ARRAY_SIZE(res->supplies),
@@ -1183,6 +1189,9 @@ static int qcom_pcie_init_2_7_0(struct qcom_pcie *pcie)
  	if (pcie->cfg->pipe_clk_need_muxing)
  		clk_set_parent(res->pipe_clk_src, res->phy_pipe_clk);
+ if (res->path)
+		icc_set_bw(res->path, 500, 800);
+
  	ret = clk_bulk_prepare_enable(res->num_clks, res->clks);
  	if (ret < 0)
  		goto err_disable_regulators;
@@ -1241,6 +1250,8 @@ static void qcom_pcie_deinit_2_7_0(struct qcom_pcie *pcie)
  	struct qcom_pcie_resources_2_7_0 *res = &pcie->res.v2_7_0;
clk_bulk_disable_unprepare(res->num_clks, res->clks);
+	if (res->path)
+		icc_set_bw(res->path, 0, 0);
/* Set TCXO as clock source for pcie_pipe_clk_src */
  	if (pcie->cfg->pipe_clk_need_muxing)
--
2.34.1



--
With best wishes
Dmitry



[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux