On 23/02/2022 03:44, Julius Werner wrote: >>> + revision-id: >>> + $ref: /schemas/types.yaml#/definitions/uint32-array >>> + minItems: 2 >>> + maxItems: 2 >> >> You need maximum value under items. See: >> Documentation/devicetree/bindings/arm/l2c2x0.yaml > > Sorry, can you clarify how this is supposed to be? Do you want > > revision-id: > minItems: 2 > maxItems: 2 > items: > minItems: 2 > maxItems: 2 > > or just > > revision-id: > items: > minItems: 2 > maxItems: 2 > > I see examples of both in the file you linked (and also examples of > what my original patch did). There is no example of the first case in linked file. I am not sure if it is correct even... I did not ask about maximum number of items, but "maximum value", so like this: https://elixir.bootlin.com/linux/latest/source/Documentation/devicetree/bindings/arm/l2c2x0.yaml#L73 > Is there any authoritative documentation > somewhere I can read that specifies which of those is correct? (I > tried looking at > https://json-schema.org/understanding-json-schema/reference/array.html#length > but I'm not sure if that's relevant here.) example-schema.yaml is the best, but it might not cover that part. We need more docs, I know... > For updating existing DTSes, do you want that in the same patch or a > separate patch in a series? Separate patch in this series, please. Best regards, Krzysztof
