Hi Rob: Thank you for your comment and it'll be addressed. Rob Herring <robh@xxxxxxxxxx> 於 2022年2月23日 週三 上午1:56寫道： > > On Sun, Feb 20, 2022 at 11:53:12AM +0800, Tyrone Ting wrote: > > From: Tyrone Ting <kfting@xxxxxxxxxxx> > > > > Add compatible and nuvoton,sys-mgr description for NPCM i2c module. > > > > Signed-off-by: Tyrone Ting <kfting@xxxxxxxxxxx> > > Signed-off-by: Tali Perry <tali.perry1@xxxxxxxxx> > > --- > > .../bindings/i2c/nuvoton,npcm7xx-i2c.yaml | 17 ++++++++++++----- > > 1 file changed, 12 insertions(+), 5 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/i2c/nuvoton,npcm7xx-i2c.yaml b/Documentation/devicetree/bindings/i2c/nuvoton,npcm7xx-i2c.yaml > > index 128444942aec..809c51ac32fe 100644 > > --- a/Documentation/devicetree/bindings/i2c/nuvoton,npcm7xx-i2c.yaml > > +++ b/Documentation/devicetree/bindings/i2c/nuvoton,npcm7xx-i2c.yaml > > @@ -7,17 +7,18 @@ $schema: http://devicetree.org/meta-schemas/core.yaml# > > title: nuvoton NPCM7XX I2C Controller Device Tree Bindings > > > > description: | > > - The NPCM750x includes sixteen I2C bus controllers. All Controllers support > > - both master and slave mode. Each controller can switch between master and slave > > - at run time (i.e. IPMB mode). Each controller has two 16 byte HW FIFO for TX and > > - RX. > > + I2C bus controllers of the NPCM series support both master and > > + slave mode. Each controller can switch between master and slave at run time > > + (i.e. IPMB mode). HW FIFO for TX and RX are supported. > > > > maintainers: > > - Tali Perry <tali.perry1@xxxxxxxxx> > > > > properties: > > compatible: > > - const: nuvoton,npcm750-i2c > > + enum: > > + - nuvoton,npcm750-i2c > > + - nuvoton,npcm845-i2c > > > > reg: > > maxItems: 1 > > @@ -36,11 +37,16 @@ properties: > > default: 100000 > > enum: [100000, 400000, 1000000] > > > > + nuvoton,sys-mgr: > > + $ref: "/schemas/types.yaml#/definitions/phandle" > > + description: The phandle of system manager register node. > > + > > required: > > - compatible > > - reg > > - interrupts > > - clocks > > + - nuvoton,sys-mgr > > You can't make nuvoton,sys-mgr required for existing users. You can add > an if/then schema for nuvoton,npcm845-i2c if you want to make it > required in that case. > > Rob Best regards, Tyrone
