Am Donnerstag, 4. September 2014, 10:40:24 schrieb Dmitry Torokhov: > Hi Chris, > > On Thu, Sep 04, 2014 at 09:12:38AM +0800, Chris Zhong wrote: > > + rk808_clkout->clk_data.clks = clk_table; > > + rk808_clkout->clk_data.clk_num = RK808_NR_OUTPUT; > > + > > + return of_clk_add_provider(node, of_clk_src_onecell_get, > > + &rk808_clkout->clk_data); > > +} > > + > > +static struct platform_driver rk808_clkout_driver = { > > + .probe = rk808_clkout_probe, > > + .driver = { > > + .name = "rk808-clkout", > > + }, > > +}; > > Shouldn't there also be: > > static int rk808_clkout_probe(struct platform_device *pdev) ^^ remove Just to prevent confusion. And you're right there of course. Heiko > { > of_clk_del_provider(pdev->dev.of_node); > > /* The rest of resources are managed ones */ > > return 0; > } > > Thanks. -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html