On 22.02.2022 15:22, Rob Herring wrote: > On Mon, 21 Feb 2022 21:23:18 +0100, Heiner Kallweit wrote: >> Add a YAML schema binding for TM1628 auxdisplay >> (7/11-segment LED) controller. >> >> This patch is partially based on previous RFC work from >> Andreas Färber <afaerber@xxxxxxx>. >> >> Signed-off-by: Andreas Färber <afaerber@xxxxxxx> >> Signed-off-by: Heiner Kallweit <hkallweit1@xxxxxxxxx> >> --- >> v2: >> - (re-)add Andreas' SoB >> - fix YAML errors reported by Rob >> --- >> .../bindings/auxdisplay/titanmec,tm1628.yaml | 88 +++++++++++++++++++ >> 1 file changed, 88 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/auxdisplay/titanmec,tm1628.yaml >> > > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' > on your patch (DT_CHECKER_FLAGS is new in v5.13): > > yamllint warnings/errors: > > dtschema/dtc warnings/errors: > /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/auxdisplay/titanmec,tm1628.example.dt.yaml: led-controller@0: 'spi-3-wire', 'spi-lsb-first', 'spi-max-frequency' do not match any of the regexes: '^.*@[1-7],([1-9]|1[0-6])$', 'pinctrl-[0-9]+' > From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/auxdisplay/titanmec,tm1628.yaml > > doc reference errors (make refcheckdocs): > > See https://patchwork.ozlabs.org/patch/1595730 > > This check can fail if there are any dependencies. The base for a patch > series is generally the most recent rc1. > > If you already ran 'make dt_binding_check' and didn't see the above > error(s), then make sure 'yamllint' is installed and dt-schema is up to > date: > > pip3 install dtschema --upgrade > > Please check and re-submit. > When I run "make DT_CHECKER_FLAGS=-m dt_binding_check" then this error isn't reported. I have: > yamllint -v yamllint 1.26.2 > dt-doc-validate --version 2022.2.dev1+gf677c85 > pip show dtschema Name: dtschema Version: 2022.2.dev1+gf677c85 Summary: DeviceTree validation schema and tools Home-page: https://github.com/devicetree-org/dt-schema Author: Rob Herring Author-email: robh@xxxxxxxxxx License: BSD Location: /usr/lib/python3.10/site-packages Requires: ruamel.yaml, jsonschema, rfc3987 Required-by: What else could be messing? If it matters: I'm building on latest linux-next.
