On 22-02-22, 10:03, Lukasz Luba wrote: > > > On 2/22/22 09:45, Viresh Kumar wrote: > > On 22-02-22, 08:06, Lukasz Luba wrote: > > > I'm not sure if that would be flexible enough to meet the requirement: > > > power for each OPP might be different in one board vs. other board. > > > > Don't DT files overload values from board files all the time ? Why wouldn't the > > same apply for OPP table as well ? > > In that SoC and family of the boards, there are no such examples. Here is one I think. arch/arm64/boot/dts/freescale/imx8mq-librem5-r3.dts > It used to be popular in arm32 boards, but I'm not sure nowadays. I think it is still common, not with OPPs though. > > > AFAIK the OPP definition is more SoC specific. > > > > This isn't about OPP definition as well, but just that if DT allows you to > > override or not. I think it will. > > > > Redefining the whole OPP table, when the freq, voltage, interconnect, > and other old entries don't change isn't too messy? I think you misunderstood what I said. The common part of the OPP table should stay in the central .dtsi file. The dts files though, should just add the power specific values to the existing OPP table. > As I said, I would prefer something lightweight, not redefining all > stuff from OPP in every board file. -- viresh
