Hi Krzysztof: Thank you for your comments and please find my reply next to your comments. Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxxxxx> 於 2022年2月20日 週日 下午5:32寫道: > > On 20/02/2022 04:53, Tyrone Ting wrote: > > From: Tali Perry <tali.perry1@xxxxxxxxx> > > > > Use a generic name for NPCM system manager reigster. > > The subject is not accurate and you entirely skipped in commit msg the > fact of an ABI break. > > You do not update a property name but you change the way of getting GCR > regmap. > I'll change the subject since the patch is to change the way to getting GCR regmap as you indicated. About the ABI break, I responded in the discussion thread of [PATCH v2 00/11] i2c: npcm: Bug fixes timeout, spurious interrupts. > Best regards, > Krzysztof Best regards, Tyrone