On 20/02/2022 12:48, Jonathan Cameron wrote: > On Sun, 20 Feb 2022 11:53:55 +0100 > Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxxxxx> wrote: > >> On 14/02/2022 10:41, Antoniu Miclaus wrote: >>> Add device tree bindings for the ADA4250 driver. >> >> Please put the bindings patch as first in the series. >> >>> >>> Signed-off-by: Antoniu Miclaus <antoniu.miclaus@xxxxxxxxxx> >>> --- >>> .../bindings/iio/amplifiers/adi,ada4250.yaml | 48 +++++++++++++++++++ >>> 1 file changed, 48 insertions(+) >>> create mode 100644 Documentation/devicetree/bindings/iio/amplifiers/adi,ada4250.yaml >>> >>> diff --git a/Documentation/devicetree/bindings/iio/amplifiers/adi,ada4250.yaml b/Documentation/devicetree/bindings/iio/amplifiers/adi,ada4250.yaml >>> new file mode 100644 >>> index 000000000000..22283ab48903 >>> --- /dev/null >>> +++ b/Documentation/devicetree/bindings/iio/amplifiers/adi,ada4250.yaml >>> @@ -0,0 +1,48 @@ >>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >>> +%YAML 1.2 >>> +--- >>> +$id: http://devicetree.org/schemas/iio/amplifiers/adi,ada4250.yaml# >>> +$schema: http://devicetree.org/meta-schemas/core.yaml# >>> + >>> +title: ADA4250 Programmable Gain Instrumentation Amplifier >>> + >>> +maintainers: >>> + - Antoniu Miclaus <antoniu.miclaus@xxxxxxxxxx> >>> + >>> +description: | >>> + Precision Low Power, 110kHz, 26uA, Programmable Gain Instrumentation Amplifier. >>> + >>> +properties: >>> + compatible: >>> + enum: >>> + - adi,ada4250 >>> + >>> + reg: >>> + maxItems: 1 >>> + >>> + avdd-supply: true >> >> Needs a description, not a true. > > For a generic supply where all we really have is a name, I'm not sure > a description adds anything. Of course, if there is more info that can be provided > a description is great to have. Hm, OK, if the description would be "AVDD supply", then indeed does not make much sense. > >> >> As Jonathan said, you should allow spi-max-frequency (so >> spi-max-frequency: true). >> >> No io-channel-cells? > > I'm not sure you'd have a consumer of this type of device, so > it may not make sense... OK. Best regards, Krzysztof
