On 18/02/2022 10:50, Cristian Pop wrote: > Add device tree bindings for the ADMV4420 K band downconverter. Subject needs fixes. You miss spaces there, incorrect prefix. Use git log --oneline to get the examples subject style in given subsystem. > > Signed-off-by: Cristian Pop <cristian.pop@xxxxxxxxxx> > --- > .../bindings/iio/frequency/adi,admv4420.yaml | 55 +++++++++++++++++++ > 1 file changed, 55 insertions(+) > create mode 100644 Documentation/devicetree/bindings/iio/frequency/adi,admv4420.yaml > > diff --git a/Documentation/devicetree/bindings/iio/frequency/adi,admv4420.yaml b/Documentation/devicetree/bindings/iio/frequency/adi,admv4420.yaml > new file mode 100644 > index 000000000000..35a3fb3fd339 > --- /dev/null > +++ b/Documentation/devicetree/bindings/iio/frequency/adi,admv4420.yaml > @@ -0,0 +1,55 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/iio/frequency/adi,admv4420.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: ADMV4420 K Band Downconverter > + > +maintainers: > + - Cristian Pop <cristian.pop@xxxxxxxxxx> > + > +description: > + The ADMV4420 is a highly integrated, double balanced, active > + mixer with an integrated fractional-N synthesizer, ideally suited > + for next generation K band satellite communications > + > +properties: > + compatible: > + enum: > + - adi,admv4420 > + > + reg: > + maxItems: 1 > + > + spi-max-frequency: > + maximum: 1000000 > + > + adi,lo-freq-khz: > + description: LO Frequency > + $ref: /schemas/types.yaml#/definitions/uint32 Rob's question from v3 remains unanswered... > + > + adi,ref-ext-single-ended-en: > + description: External reference selected. > + type: boolean > + > +required: > + - compatible > + - reg > + > +additionalProperties: false > + > +examples: > + - | > + spi { > + #address-cells = <1>; > + #size-cells = <0>; > + admv4420@0 { Generic node name. It's a kind of plague there... everyone using specific model as node name. > + compatible = "adi,admv4420"; > + reg = <0>; > + spi-max-frequency = <1000000>; > + adi,lo-freq-khz = <16750000>; > + adi,ref-ext-single-ended-en; > + }; > + }; > +... Best regards, Krzysztof
