On 09/03/2014 01:38 PM, Frank Li wrote: > From: Fugang Duan <B38611@xxxxxxxxxxxxx> > > Add multiqueue support, which is compatible with previous single queue > driver for FEC/ENET IPs. > > By default, the tx/rx queue number is 1, user can config the queue number > at DTS file like this: > fsl,num_tx_queues=<3>; > fsl,num_rx_queues=<3>; > > Ethernet multiqueue mechanism can improve performance in SMP system. > For single hw queue, multiqueue can balance cpu loading. > For multi hw queues, multiple cores can process network packets in parallel, > and refer the article for the detail advantage for multiqueue: > http://vger.kernel.org/~davem/davem_nyc09.pdf You should probably split that patch in a minimum of two, or more different parts. Two parts: - add TX multiqueue support - add RX multiqueue support More parts: - prepare for TX multiqueue (introduce queue structure, definitions) - transition TX path to use queue 0 - add support for the two other TX queues - prepare for RX multiqueue (introduce queue structure, definitions) - prepare for multiqueue, hardcode RX path to use queue 0 - add support for the two other RX queues The number of changes are extremely hard to review... -- Florian -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
