On Wed, Feb 09, 2022 at 05:12:20PM +0200, alexandru.tachici@xxxxxxxxxx wrote: > > On Sat, Dec 11, 2021 at 10:07:49PM +0100, Andrew Lunn wrote: > > > > + ret = phy_read_mmd(phydev, MDIO_MMD_PMAPMD, MDIO_PMA_EXTABLE); > > > > + if (ret < 0) > > > > + return ret; > > > > + > > > > + if (ret & MDIO_PMA_EXTABLE_BT1) > > > > > > > > > This pattern of reading the MDIO_PMA_EXTABLE register and then looking > > > for bit MDIO_PMA_EXTABLE_BT1 happens a lot. It is not something which > > > is expected to change is it? So i wounder if it should be read once > > > and stored away? > > > > What is the state of this patches? Will you be able to make requested > > changes and send new version? > > I will come back with a V5 where I will add the requested changes. I tested your patches with TI dp83td510. With some minor quirks on TI side it seems to work fine. So you can have my: Tested-by: Oleksij Rempel <o.rempel@xxxxxxxxxxxxxx> -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
