On 15/02/2022 16:15, Markuss Broks wrote: > This patch adds device-tree bindings for the Imagis > IST3038C touch screen IC. > > Signed-off-by: Markuss Broks <markuss.broks@xxxxxxxxx> > --- > .../input/touchscreen/imagis,ist3038c.yaml | 75 +++++++++++++++++++ > .../devicetree/bindings/vendor-prefixes.yaml | 2 + > 2 files changed, 77 insertions(+) > create mode 100644 Documentation/devicetree/bindings/input/touchscreen/imagis,ist3038c.yaml > > diff --git a/Documentation/devicetree/bindings/input/touchscreen/imagis,ist3038c.yaml b/Documentation/devicetree/bindings/input/touchscreen/imagis,ist3038c.yaml > new file mode 100644 > index 000000000000..7b127817e1f6 > --- /dev/null > +++ b/Documentation/devicetree/bindings/input/touchscreen/imagis,ist3038c.yaml > @@ -0,0 +1,75 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/input/touchscreen/imagis,ist3038c.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Imagis IST30XXC family touchscreen controller bindings > + > +maintainers: > + - Markuss Broks <markuss.broks@xxxxxxxxx> > + > +allOf: > + - $ref: touchscreen.yaml# > + > +properties: > + $nodename: > + pattern: "^touchscreen(@.*)?$" reg is required, so @ is not optional: ^touchscreen@[0-9a-f]+$ > + > + compatible: > + items: Do you expect here multiple compatibles? If not, the items are not needed. > + - enum: > + - imagis,ist3038c > + > + reg: > + description: I2C address You can skip description because it is fairly obvious, but instead you need maxItems. Alternatively, a list (items) with description defines max items. Best regards, Krzysztof
