Hi Satya, Thank you for the patch! Yet something to improve: [auto build test ERROR on next-20220214] [also build test ERROR on v5.17-rc4] [cannot apply to robh/for-next broonie-regulator/for-next lee-mfd/for-mfd-next v5.17-rc4 v5.17-rc3 v5.17-rc2] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Satya-Priya/Add-Qualcomm-Technologies-Inc-PM8008-regulator-driver/20220215-165525 base: 259cbfc98c55ba3b6ef6e61fb7cfc3751dfded1e config: sh-allmodconfig (https://download.01.org/0day-ci/archive/20220215/202202152228.Mmfx9SWj-lkp@xxxxxxxxx/config) compiler: sh4-linux-gcc (GCC) 11.2.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/0day-ci/linux/commit/12b686033a10eae2956b1c8436bfaa8c411baa92 git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Satya-Priya/Add-Qualcomm-Technologies-Inc-PM8008-regulator-driver/20220215-165525 git checkout 12b686033a10eae2956b1c8436bfaa8c411baa92 # save the config file to linux build tree mkdir build_dir COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=sh SHELL=/bin/bash drivers/mfd/ If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp@xxxxxxxxx> All errors (new ones prefixed by >>): >> drivers/mfd/qcom-pm8008.c:272:1: error: expected ',' or ';' before 'static' 272 | static struct i2c_driver pm8008_mfd_driver = { | ^~~~~~ In file included from drivers/mfd/qcom-pm8008.c:7: drivers/mfd/qcom-pm8008.c: In function 'pm8008_mfd_driver_init': >> drivers/mfd/qcom-pm8008.c:279:19: error: 'pm8008_mfd_driver' undeclared (first use in this function); did you mean 'pm8008_mfd_driver_init'? 279 | module_i2c_driver(pm8008_mfd_driver); | ^~~~~~~~~~~~~~~~~ include/linux/i2c.h:886:42: note: in definition of macro 'i2c_add_driver' 886 | i2c_register_driver(THIS_MODULE, driver) | ^~~~~~ include/linux/i2c.h:954:9: note: in expansion of macro 'module_driver' 954 | module_driver(__i2c_driver, i2c_add_driver, \ | ^~~~~~~~~~~~~ drivers/mfd/qcom-pm8008.c:279:1: note: in expansion of macro 'module_i2c_driver' 279 | module_i2c_driver(pm8008_mfd_driver); | ^~~~~~~~~~~~~~~~~ drivers/mfd/qcom-pm8008.c:279:19: note: each undeclared identifier is reported only once for each function it appears in 279 | module_i2c_driver(pm8008_mfd_driver); | ^~~~~~~~~~~~~~~~~ include/linux/i2c.h:886:42: note: in definition of macro 'i2c_add_driver' 886 | i2c_register_driver(THIS_MODULE, driver) | ^~~~~~ include/linux/i2c.h:954:9: note: in expansion of macro 'module_driver' 954 | module_driver(__i2c_driver, i2c_add_driver, \ | ^~~~~~~~~~~~~ drivers/mfd/qcom-pm8008.c:279:1: note: in expansion of macro 'module_i2c_driver' 279 | module_i2c_driver(pm8008_mfd_driver); | ^~~~~~~~~~~~~~~~~ In file included from include/linux/device.h:32, from include/linux/acpi.h:15, from include/linux/i2c.h:13, from drivers/mfd/qcom-pm8008.c:7: drivers/mfd/qcom-pm8008.c: In function 'pm8008_mfd_driver_exit': drivers/mfd/qcom-pm8008.c:279:19: error: 'pm8008_mfd_driver' undeclared (first use in this function); did you mean 'pm8008_mfd_driver_exit'? 279 | module_i2c_driver(pm8008_mfd_driver); | ^~~~~~~~~~~~~~~~~ include/linux/device/driver.h:267:24: note: in definition of macro 'module_driver' 267 | __unregister(&(__driver) , ##__VA_ARGS__); \ | ^~~~~~~~ drivers/mfd/qcom-pm8008.c:279:1: note: in expansion of macro 'module_i2c_driver' 279 | module_i2c_driver(pm8008_mfd_driver); | ^~~~~~~~~~~~~~~~~ drivers/mfd/qcom-pm8008.c: In function 'pm8008_mfd_driver_init': include/linux/device/driver.h:263:1: error: control reaches end of non-void function [-Werror=return-type] 263 | } \ | ^ include/linux/i2c.h:954:9: note: in expansion of macro 'module_driver' 954 | module_driver(__i2c_driver, i2c_add_driver, \ | ^~~~~~~~~~~~~ drivers/mfd/qcom-pm8008.c:279:1: note: in expansion of macro 'module_i2c_driver' 279 | module_i2c_driver(pm8008_mfd_driver); | ^~~~~~~~~~~~~~~~~ At top level: drivers/mfd/qcom-pm8008.c:230:12: warning: 'pm8008_probe' defined but not used [-Wunused-function] 230 | static int pm8008_probe(struct i2c_client *client) | ^~~~~~~~~~~~ cc1: some warnings being treated as errors Kconfig warnings: (for reference only) WARNING: unmet direct dependencies detected for SND_SOC_LPASS_RX_MACRO Depends on SOUND && !UML && SND && SND_SOC && COMMON_CLK Selected by - SND_SOC_SC7280 && SOUND && !UML && SND && SND_SOC && SND_SOC_QCOM && (I2C && SOUNDWIRE || COMPILE_TEST WARNING: unmet direct dependencies detected for SND_SOC_LPASS_TX_MACRO Depends on SOUND && !UML && SND && SND_SOC && COMMON_CLK Selected by - SND_SOC_SC7280 && SOUND && !UML && SND && SND_SOC && SND_SOC_QCOM && (I2C && SOUNDWIRE || COMPILE_TEST vim +272 drivers/mfd/qcom-pm8008.c 6b149f3310a466 Guru Das Srinagesh 2021-05-25 271 6b149f3310a466 Guru Das Srinagesh 2021-05-25 @272 static struct i2c_driver pm8008_mfd_driver = { 6b149f3310a466 Guru Das Srinagesh 2021-05-25 273 .driver = { 6b149f3310a466 Guru Das Srinagesh 2021-05-25 274 .name = "pm8008", 6b149f3310a466 Guru Das Srinagesh 2021-05-25 275 .of_match_table = pm8008_match, 6b149f3310a466 Guru Das Srinagesh 2021-05-25 276 }, 6b149f3310a466 Guru Das Srinagesh 2021-05-25 277 .probe_new = pm8008_probe, 6b149f3310a466 Guru Das Srinagesh 2021-05-25 278 }; 6b149f3310a466 Guru Das Srinagesh 2021-05-25 @279 module_i2c_driver(pm8008_mfd_driver); 6b149f3310a466 Guru Das Srinagesh 2021-05-25 280 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx