Hi Marek, I love your patch! Perhaps something to improve: [auto build test WARNING on clk/clk-next] [also build test WARNING on v5.17-rc4 next-20220215] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Marek-Vasut/dt-bindings-clk-Introduce-critical-clocks-property/20220215-164757 base: https://git.kernel.org/pub/scm/linux/kernel/git/clk/linux.git clk-next config: x86_64-randconfig-a002-20220214 (https://download.01.org/0day-ci/archive/20220215/202202152152.8a7M9Tkv-lkp@xxxxxxxxx/config) compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project 37f422f4ac31c8b8041c6b62065263314282dab6) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/0day-ci/linux/commit/aded04bc3dec13df3f940621d94d84e32ff8a5ea git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Marek-Vasut/dt-bindings-clk-Introduce-critical-clocks-property/20220215-164757 git checkout aded04bc3dec13df3f940621d94d84e32ff8a5ea # save the config file to linux build tree mkdir build_dir COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash drivers/clk/ If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp@xxxxxxxxx> All warnings (new ones prefixed by >>): >> drivers/clk/clk.c:3881:6: warning: variable 'ret' set but not used [-Wunused-but-set-variable] int ret, i, index; ^ 1 warning generated. vim +/ret +3881 drivers/clk/clk.c 3874 3875 static void 3876 __clk_register_critical_clock(struct device_node *np, struct clk_core *core, 3877 struct clk_hw *hw) 3878 { 3879 struct of_phandle_args clkspec; 3880 u32 clksize, clktotal; > 3881 int ret, i, index; 3882 3883 if (!np) 3884 return; 3885 3886 if (!core->ops->match_clkspec) 3887 return; 3888 3889 if (of_property_read_u32(np, "#clock-cells", &clksize)) 3890 return; 3891 3892 /* Clock node with #clock-cells = <0> uses critical-clocks; */ 3893 if (clksize == 0) { 3894 if (of_property_read_bool(np, "critical-clocks") && 3895 !core->ops->match_clkspec(hw, &clkspec)) 3896 core->flags |= CLK_IS_CRITICAL; 3897 return; 3898 } 3899 3900 clkspec.np = np; 3901 clktotal = of_property_count_u32_elems(np, "critical-clocks"); 3902 clktotal /= clksize; 3903 for (index = 0; index < clktotal; index++) { 3904 for (i = 0; i < clksize; i++) { 3905 ret = of_property_read_u32_index(np, "critical-clocks", 3906 (index * clksize) + i, 3907 &(clkspec.args[i])); 3908 } 3909 if (!core->ops->match_clkspec(hw, &clkspec)) 3910 core->flags |= CLK_IS_CRITICAL; 3911 } 3912 } 3913 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx
