On Mon, Feb 14, 2022 at 10:50:21PM +0100, Krzysztof Kozlowski wrote: > On 12/02/2022 00:31, Danilo Krummrich wrote: > > The PS/2 bus defines the data and clock line be open drain, therefore > > document this in the dt-binding and enforce the particular flag in the > > driver. > > > > Without enforcing to flag at least the clock gpio as open drain we run > > into the following warning: > > > > WARNING: CPU: 1 PID: 40 at drivers/gpio/gpiolib.c:3175 gpiochip_enable_irq+0x54/0x90 > > > > gpiochip_enable_irq() warns on a GPIO being configured as output and > > using IRQ without being flagged as open drain. > > > > Signed-off-by: Danilo Krummrich <danilokrummrich@xxxxxxxxxxxxx> > > --- > > .../devicetree/bindings/serio/ps2-gpio.yaml | 14 ++++++++++---- > > drivers/input/serio/ps2-gpio.c | 9 +++++++-- > > 2 files changed, 17 insertions(+), 6 deletions(-) > > > > Bindings as separate patch, please. Are you fine with adding this additional documentation directly to the patch converting the binding to a json-schema or do you prefer it to be a separate patch? > > Best regards, > Krzysztof - Danilo
