On 11/02/2022 20:16:27+0000, Hugo Villeneuve wrote: > > > Actually, this property has to be made more generic and thought > > > out. > > > There are multiple RTCs that have multiple interrupt pins where one > > > of > > > the pin can be used for different interrupt or clock output. > > Hi, > the only example I could find of such a device is in rtc-pcf85363.c. > This device also has two interrupt pins, INT A/B, like the PCF2131. > However, in the pcf85363 driver, pin INT B is simply ignored, and all > interrupts are configured to go on INT A. > Yes, this was the RTC for which we had that discussion last time but there is also pcf8523 and other non NXP RTCs. > For the moment, I will simply modify my PCF2131 patches serie to mimic > the same behavior in V2. This simplifies things a lot, and support for > INT B pin could be added at a later stage (and also to pcf85363) if > anyone needs it (I don't). > > Hugo. > > > > With your binding, there is no way to separate which interrupt is > > > going > > > to which pin and so there is no way to get the alarm and BLF or the > > > watchdog on different pins and we certainly don't want to have a > > > property per interrupt type. > > > > Hi, > > can you please suggest how you would prefer it to be done? > > > > > Also, the documentation is missing the fact that the driver makes > > > having > > > one of the property mandatory. > > > > I will add it. > > > > Thank you, Hugo. > > > -- Alexandre Belloni, co-owner and COO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
