Hi Markuss, One tiny correction to my previous feedback. On Thu, Feb 10, 2022 at 06:01:03PM -0600, Jeff LaBundy wrote: > Hi Markuss, > > Neat little driver! Some humble feedback below. > [...] > > + error = input_register_device(input_dev); > > + if (error) { > > + dev_err(&ts->client->dev, > > + "Failed to register input device: %d", error); > > + return error; > > + } > > I suggest using the device-managed version here, as you have no remove callback. > Please ignore this bit :) [...] Kind regards, Jeff LaBundy