On 2/10/2022 5:37 AM, Stephen Boyd wrote:
Thanks for Your time Stephen!!!
Quoting Srinivasa Rao Mandadapu (2022-02-09 05:42:40)
On 2/9/2022 2:38 AM, Stephen Boyd wrote:
Quoting Srinivasa Rao Mandadapu (2022-02-08 07:34:12)
&qspi_cs0 {
bias-disable;
@@ -491,6 +524,13 @@
};
&tlmm {
+ amp_en: amp-en {
+ pins = "gpio63";
+ function = "gpio";
+ bias-disable;
Is there an external pull?
I think no external pull. In trogdor mentioned bias-pull-down but you
suggested to remove it.
Maybe on trogdor there was an external pull inside the amp that this pin
is connected to? Usually we have a comment like /* Has external
pull-{up,down} */ so please add that here depending on which way the
pull goes.
As per Anderson suggestion we removed bias-pull-down. Actually, it's
up-streamed for same platform in sc7280-herobrine.dtsi.
We will fallow the same. It contains bias-pull-down.
