On 10/02/2022 10:34, Corentin Labbe wrote:
> Convert watchdog/faraday,ftwdt010.txt to yaml.
> This permits to detect missing properties like clocks and resets or
> compatible like moxa,moxart-watchdog.
>
> Reviewed-by: Linus Walleij <linus.walleij@xxxxxxxxxx>
> Signed-off-by: Corentin Labbe <clabbe@xxxxxxxxxxxx>
> ---
> Changes since v1:
> - Added myself as maintainer as requested by Linus
> - Added $ref to watchdog.yaml
> - Removed useless quotes
> - Added blank lines between properties
> - Removed timeout-sec as already provided by watchdog.yaml
>
> .../bindings/watchdog/faraday,ftwdt010.txt | 22 ------
> .../bindings/watchdog/faraday,ftwdt010.yaml | 67 +++++++++++++++++++
> 2 files changed, 67 insertions(+), 22 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/watchdog/faraday,ftwdt010.txt
> create mode 100644 Documentation/devicetree/bindings/watchdog/faraday,ftwdt010.yaml
>
> diff --git a/Documentation/devicetree/bindings/watchdog/faraday,ftwdt010.txt b/Documentation/devicetree/bindings/watchdog/faraday,ftwdt010.txt
> deleted file mode 100644
> index 9ecdb502e605..000000000000
> --- a/Documentation/devicetree/bindings/watchdog/faraday,ftwdt010.txt
> +++ /dev/null
> @@ -1,22 +0,0 @@
> -Faraday Technology FTWDT010 watchdog
> -
> -This is an IP part from Faraday Technology found in the Gemini
> -SoCs and others.
> -
> -Required properties:
> -- compatible : must be one of
> - "faraday,ftwdt010"
> - "cortina,gemini-watchdog", "faraday,ftwdt010"
> -- reg : shall contain base register location and length
> -- interrupts : shall contain the interrupt for the watchdog
> -
> -Optional properties:
> -- timeout-sec : the default watchdog timeout in seconds.
> -
> -Example:
> -
> -watchdog@41000000 {
> - compatible = "faraday,ftwdt010";
> - reg = <0x41000000 0x1000>;
> - interrupts = <3 IRQ_TYPE_LEVEL_HIGH>;
> -};
> diff --git a/Documentation/devicetree/bindings/watchdog/faraday,ftwdt010.yaml b/Documentation/devicetree/bindings/watchdog/faraday,ftwdt010.yaml
> new file mode 100644
> index 000000000000..64e9c414cc60
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/watchdog/faraday,ftwdt010.yaml
> @@ -0,0 +1,67 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/watchdog/faraday,ftwdt010.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Faraday Technology FTWDT010 watchdog
> +
> +maintainers:
> + - Linus Walleij <linus.walleij@xxxxxxxxxx>
> + - Corentin Labbe <clabbe@xxxxxxxxxxxx>
> +
> +description: |
> + This is an IP part from Faraday Technology found in the Gemini
> + SoCs and others.
> +
> +allOf:
> + - $ref: "watchdog.yaml#"
> +
> +properties:
> + compatible:
> + oneOf:
> + - const: faraday,ftwdt010
> + - items:
> + - const: cortina,gemini-watchdog
> + - const: faraday,ftwdt010
> + - items:
> + - const: moxa,moxart-watchdog
> + - const: faraday,ftwdt010
It looks like you duplicated these two entries. This should be an enum
followed by a const.
Best regards,
Krzysztof
