On Wed, Feb 09, 2022 at 09:51:06AM +0100, Michael Riesch wrote: > From: Alex Bee <knaerzche@xxxxxxxxx> > > The Bifrost GPU in Rockchip RK356x SoCs has a core and a bus clock. > Reflect this in the SoC specific part of the binding. > > Signed-off-by: Alex Bee <knaerzche@xxxxxxxxx> > [move the changes to the SoC section] > Signed-off-by: Michael Riesch <michael.riesch@xxxxxxxxxxxxxx> > --- > .../devicetree/bindings/gpu/arm,mali-bifrost.yaml | 15 +++++++++++++++ > 1 file changed, 15 insertions(+) > > diff --git a/Documentation/devicetree/bindings/gpu/arm,mali-bifrost.yaml b/Documentation/devicetree/bindings/gpu/arm,mali-bifrost.yaml > index 63a08f3f321d..21409c8d3813 100644 > --- a/Documentation/devicetree/bindings/gpu/arm,mali-bifrost.yaml > +++ b/Documentation/devicetree/bindings/gpu/arm,mali-bifrost.yaml > @@ -159,6 +159,21 @@ allOf: > power-domains: > maxItems: 1 > sram-supply: false > + - if: > + properties: > + compatible: > + contains: > + const: rockchip,rk3568-mali > + then: > + properties: > + clocks: > + minItems: 2 > + clock-names: > + items: > + - const: core > + - const: bus Please don't invent new names. We already have 'gpu' and 'bus' defined. 'core' and 'gpu' sound like the same thing to me, and the h/w doesn't have different clocks from vendor to vendor. Rob