Hi, Am Mittwoch, 9. Februar 2022, 04:38:15 CET schrieb zyf@xxxxxxxxxxxxxx: > Hi Rob, > > We move "rockchip,rk3568-pipe-grf" from syscon.yaml to grf.yaml. > How to fix this compilation failed? as you can see in the example, there is already a #include <dt-bindings/clock/rk3568-cru.h> so you probably just need to add another include for the grf.yaml Heiko > > diff --git a/Documentation/devicetree/bindings/mfd/syscon.yaml b/Documentation/devicetree/bindings/mfd/syscon.yaml > index fdd96e378df0..e9bb96ab9446 100644 > --- a/Documentation/devicetree/bindings/mfd/syscon.yaml > +++ b/Documentation/devicetree/bindings/mfd/syscon.yaml > @@ -52,6 +52,8 @@ properties: > - rockchip,rk3288-qos > - rockchip,rk3368-qos > - rockchip,rk3399-qos > + - rockchip,rk3568-pipe-grf > + - rockchip,rk3568-pipe-phy-grf > > > >On Tue, 08 Feb 2022 17:13:24 +0800, Yifeng Zhao wrote: > >> Add the compatible strings for the Naneng combo PHY found on rockchip SoC. > >> > >> Reviewed-by: Rob Herring <robh@xxxxxxxxxx> > >> Signed-off-by: Yifeng Zhao <yifeng.zhao@xxxxxxxxxxxxxx> > >> Signed-off-by: Johan Jonker <jbx6244@xxxxxxxxx> > >> --- > >> > >> Changes in v8: None > >> Changes in v7: > >> - remove u3otg0_port_en, u3otg1_port_en and pipe_sgmii_mac_sel > >> > >> Changes in v5: > >> - modify description for ssc and ext-refclk > >> - remove apb reset > >> > >> Changes in v4: > >> - restyle > >> - remove some minItems > >> - add more properties > >> - remove reset-names > >> - move #phy-cells > >> - add rockchip,rk3568-pipe-grf > >> - add rockchip,rk3568-pipe-phy-grf > >> > >> Changes in v3: None > >> Changes in v2: > >> - Fix dtschema/dtc warnings/errors > >> > >> .../phy/phy-rockchip-naneng-combphy.yaml | 109 ++++++++++++++++++ > >> 1 file changed, 109 insertions(+) > >> create mode 100644 Documentation/devicetree/bindings/phy/phy-rockchip-naneng-combphy.yaml > >> > > > >My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' > >on your patch (DT_CHECKER_FLAGS is new in v5.13): > > > >yamllint warnings/errors: > > > >dtschema/dtc warnings/errors: > >Documentation/devicetree/bindings/phy/phy-rockchip-naneng-combphy.example.dt.yaml:0:0: /example-0/syscon@fdc50000: failed to match any schema with compatible: ['rockchip,rk3568-pipe-grf', 'syscon'] > >Documentation/devicetree/bindings/phy/phy-rockchip-naneng-combphy.example.dt.yaml:0:0: /example-0/syscon@fdc70000: failed to match any schema with compatible: ['rockchip,rk3568-pipe-phy-grf', 'syscon'] > > > >doc reference errors (make refcheckdocs): > > > >See https://patchwork.ozlabs.org/patch/1589719 > > > >This check can fail if there are any dependencies. The base for a patch > >series is generally the most recent rc1. > > > >If you already ran 'make dt_binding_check' and didn't see the above > >error(s), then make sure 'yamllint' is installed and dt-schema is up to > >date: > > > >pip3 install dtschema --upgrade > > > >Please check and re-submit. > > >