On 08/02/2022 11:49, Tudor Ambarus wrote: > Convert Atmel SHA documentation to yaml format. With the conversion the > clock and clock-names properties are made mandatory. The driver returns > -EINVAL if "sha_clk" is not found, reflect that in the bindings and make > the clock and clock-names properties mandatory. Update the example to > better describe how one should define the dt node. > > Signed-off-by: Tudor Ambarus <tudor.ambarus@xxxxxxxxxxxxx> > --- > .../crypto/atmel,at91sam9g46-sha.yaml | 59 +++++++++++++++++++ > .../bindings/crypto/atmel-crypto.txt | 25 -------- > 2 files changed, 59 insertions(+), 25 deletions(-) > create mode 100644 Documentation/devicetree/bindings/crypto/atmel,at91sam9g46-sha.yaml > delete mode 100644 Documentation/devicetree/bindings/crypto/atmel-crypto.txt > > diff --git a/Documentation/devicetree/bindings/crypto/atmel,at91sam9g46-sha.yaml b/Documentation/devicetree/bindings/crypto/atmel,at91sam9g46-sha.yaml > new file mode 100644 > index 000000000000..e454f4468dc5 > --- /dev/null > +++ b/Documentation/devicetree/bindings/crypto/atmel,at91sam9g46-sha.yaml > @@ -0,0 +1,59 @@ > +# SPDX-License-Identifier: GPL-2.0-only > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/crypto/atmel,at91sam9g46-sha.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Atmel Secure Hash Algorithm (SHA) HW cryptographic accelerator > + > +maintainers: > + - Tudor Ambarus <tudor.ambarus@xxxxxxxxxxxxx> > + > +properties: > + compatible: > + const: atmel,at91sam9g46-sha > + > + reg: > + maxItems: 1 > + > + interrupts: > + maxItems: 1 > + > + clocks: > + maxItems: 1 > + > + clock-names: > + const: sha_clk > + > + dmas: > + maxItems: 1 > + description: TX DMA Channel > + One-item-description should work as well, so if you are going to resend: + dmas: + items: + - description: TX DMA Channel but the code looks equivalent, so: Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxxxxx> Best regards, Krzysztof