On Tue, Feb 08, 2022 at 11:15:30AM +0000, Joel Stanley wrote: > On Tue, 8 Feb 2022 at 11:08, Greg Kroah-Hartman > <gregkh@xxxxxxxxxxxxxxxxxxx> wrote: > > > > On Wed, Feb 02, 2022 at 03:48:32PM +0100, Iwona Winiarska wrote: > > > PECI devices may not be discoverable at the time when PECI controller is > > > being added (e.g. BMC can boot up when the Host system is still in S5). > > > Since we currently don't have the capabilities to figure out the Host > > > system state inside the PECI subsystem itself, we have to rely on > > > userspace to do it for us. > > > > > > In the future, PECI subsystem may be expanded with mechanisms that allow > > > us to avoid depending on userspace interaction (e.g. CPU presence could > > > be detected using GPIO, and the information on whether it's discoverable > > > could be obtained over IPMI). > > > Unfortunately, those methods may ultimately not be available (support > > > will vary from platform to platform), which means that we still need > > > platform independent method triggered by userspace. > > > > > > Signed-off-by: Iwona Winiarska <iwona.winiarska@xxxxxxxxx> > > > --- > > > Documentation/ABI/testing/sysfs-bus-peci | 16 +++++ > > > drivers/peci/Makefile | 2 +- > > > drivers/peci/core.c | 3 +- > > > drivers/peci/device.c | 1 + > > > drivers/peci/internal.h | 5 ++ > > > drivers/peci/sysfs.c | 82 ++++++++++++++++++++++++ > > > 6 files changed, 107 insertions(+), 2 deletions(-) > > > create mode 100644 Documentation/ABI/testing/sysfs-bus-peci > > > create mode 100644 drivers/peci/sysfs.c > > > > > > diff --git a/Documentation/ABI/testing/sysfs-bus-peci b/Documentation/ABI/testing/sysfs-bus-peci > > > new file mode 100644 > > > index 000000000000..56c2b2216bbd > > > --- /dev/null > > > +++ b/Documentation/ABI/testing/sysfs-bus-peci > > > @@ -0,0 +1,16 @@ > > > +What: /sys/bus/peci/rescan > > > +Date: July 2021 > > > +KernelVersion: 5.15 > > > > 5.15 was a long time ago :( > > > > > > Other than this nit, these all look semi-sane to me. What tree are you > > wanting these to go through, mine? If so, can you fix this up (both > > places in this file) and resend? > > Yes, I recommend Iwona send these through your tree. > > Thanks for taking another look over them. Thanks to Iwona and Intel > for doing this work. Can you provide an ack or reviewed-by for them when they are reposted so I know this? thanks, greg k-h
