On Fri, 2022-02-04 at 19:27 -0800, Jakub Kicinski wrote: > > + for (i = 0; i < dev->mib_cnt; i++) { > > + memcpy(buf + i * ETH_GSTRING_LEN, lan937x_mib_names[i].string, > > + ETH_GSTRING_LEN); > > + } > > parenthesis unnecessary around single expression > > Also check out ethtool_sprintf(), although not strictly necessary since > you're not formatting Sure, thanks for the feedback. Prasanna V