On 07.02.2022 15:25, Tudor Ambarus - M18064 wrote:
> On 2/7/22 13:15, Claudiu Beznea wrote:
>> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>>
>> Remove status = "okay" from SoC specific dtsi as this is the default
>> state.
>>
>> Signed-off-by: Claudiu Beznea <claudiu.beznea@xxxxxxxxxxxxx>
>
> Do you want do be consistent across 5d3 as well?
>
> git grep okay arch/arm/boot/dts/sama5d*.dtsi
> arch/arm/boot/dts/sama5d3xcm.dtsi: status = "okay";
> arch/arm/boot/dts/sama5d3xcm.dtsi: status = "okay";
> arch/arm/boot/dts/sama5d3xcm_cmp.dtsi: status = "okay";
> arch/arm/boot/dts/sama5d3xcm_cmp.dtsi: status = "okay";
> arch/arm/boot/dts/sama5d3xdm.dtsi: status = "okay";
> arch/arm/boot/dts/sama5d3xmb.dtsi: status = "okay";
> arch/arm/boot/dts/sama5d3xmb.dtsi: status = "okay";
> arch/arm/boot/dts/sama5d3xmb.dtsi: status = "okay";
> arch/arm/boot/dts/sama5d3xmb.dtsi: status = "okay";
> arch/arm/boot/dts/sama5d3xmb.dtsi: status = "okay";
> arch/arm/boot/dts/sama5d3xmb.dtsi: status = "okay";
> arch/arm/boot/dts/sama5d3xmb.dtsi: status = "okay";
> arch/arm/boot/dts/sama5d3xmb.dtsi: status = "okay";
> arch/arm/boot/dts/sama5d3xmb.dtsi: status = "okay";
> arch/arm/boot/dts/sama5d3xmb_cmp.dtsi: status = "okay";
> arch/arm/boot/dts/sama5d3xmb_cmp.dtsi: status = "okay";
> arch/arm/boot/dts/sama5d3xmb_cmp.dtsi: status = "okay";
> arch/arm/boot/dts/sama5d3xmb_cmp.dtsi: status = "okay";
> arch/arm/boot/dts/sama5d3xmb_cmp.dtsi: status = "okay";
> arch/arm/boot/dts/sama5d3xmb_cmp.dtsi: status = "okay";
> arch/arm/boot/dts/sama5d3xmb_cmp.dtsi: status = "okay";
> arch/arm/boot/dts/sama5d3xmb_cmp.dtsi: status = "okay";
All these are for some kind of SoMs as far as I can tell. I only treated
SoCs as the SoMs dtsi may include SoC dtsi and do status = "okay" to enable
explicitly what has been disabled in SoC dtsi.
Thank you,
Claudiu Beznea
>
> Either way, feel free to add:
> Reviewed-by: Tudor Ambarus <tudor.ambarus@xxxxxxxxxxxxx>
>
>> ---
>> arch/arm/boot/dts/sam9x60.dtsi | 4 ----
>> arch/arm/boot/dts/sama5d2.dtsi | 3 ---
>> arch/arm/boot/dts/sama5d4.dtsi | 3 ---
>> arch/arm/boot/dts/sama7g5.dtsi | 3 ---
>> 4 files changed, 13 deletions(-)
>>
>> diff --git a/arch/arm/boot/dts/sam9x60.dtsi b/arch/arm/boot/dts/sam9x60.dtsi
>> index ec45ced3cde6..e3afa1dae207 100644
>> --- a/arch/arm/boot/dts/sam9x60.dtsi
>> +++ b/arch/arm/boot/dts/sam9x60.dtsi
>> @@ -280,7 +280,6 @@ sha: sha@f002c000 {
>> dma-names = "tx";
>> clocks = <&pmc PMC_TYPE_PERIPHERAL 41>;
>> clock-names = "sha_clk";
>> - status = "okay";
>> };
>>
>> trng: trng@f0030000 {
>> @@ -288,7 +287,6 @@ trng: trng@f0030000 {
>> reg = <0xf0030000 0x100>;
>> interrupts = <38 IRQ_TYPE_LEVEL_HIGH 0>;
>> clocks = <&pmc PMC_TYPE_PERIPHERAL 38>;
>> - status = "okay";
>> };
>>
>> aes: aes@f0034000 {
>> @@ -304,7 +302,6 @@ AT91_XDMAC_DT_PERID(32))>,
>> dma-names = "tx", "rx";
>> clocks = <&pmc PMC_TYPE_PERIPHERAL 39>;
>> clock-names = "aes_clk";
>> - status = "okay";
>> };
>>
>> tdes: tdes@f0038000 {
>> @@ -320,7 +317,6 @@ AT91_XDMAC_DT_PERID(31))>,
>> dma-names = "tx", "rx";
>> clocks = <&pmc PMC_TYPE_PERIPHERAL 40>;
>> clock-names = "tdes_clk";
>> - status = "okay";
>> };
>>
>> classd: classd@f003c000 {
>> diff --git a/arch/arm/boot/dts/sama5d2.dtsi b/arch/arm/boot/dts/sama5d2.dtsi
>> index 09c741e8ecb8..05ab16ffa8bb 100644
>> --- a/arch/arm/boot/dts/sama5d2.dtsi
>> +++ b/arch/arm/boot/dts/sama5d2.dtsi
>> @@ -316,7 +316,6 @@ sha@f0028000 {
>> dma-names = "tx";
>> clocks = <&pmc PMC_TYPE_PERIPHERAL 12>;
>> clock-names = "sha_clk";
>> - status = "okay";
>> };
>>
>> aes@f002c000 {
>> @@ -332,7 +331,6 @@ AT91_XDMAC_DT_PERID(26))>,
>> dma-names = "tx", "rx";
>> clocks = <&pmc PMC_TYPE_PERIPHERAL 9>;
>> clock-names = "aes_clk";
>> - status = "okay";
>> };
>>
>> spi0: spi@f8000000 {
>> @@ -1097,7 +1095,6 @@ AT91_XDMAC_DT_PERID(28))>,
>> dma-names = "tx", "rx";
>> clocks = <&pmc PMC_TYPE_PERIPHERAL 11>;
>> clock-names = "tdes_clk";
>> - status = "okay";
>> };
>>
>> classd: classd@fc048000 {
>> diff --git a/arch/arm/boot/dts/sama5d4.dtsi b/arch/arm/boot/dts/sama5d4.dtsi
>> index f6e3e6f57252..4de164905e03 100644
>> --- a/arch/arm/boot/dts/sama5d4.dtsi
>> +++ b/arch/arm/boot/dts/sama5d4.dtsi
>> @@ -684,7 +684,6 @@ aes@fc044000 {
>> dma-names = "tx", "rx";
>> clocks = <&pmc PMC_TYPE_PERIPHERAL 12>;
>> clock-names = "aes_clk";
>> - status = "okay";
>> };
>>
>> tdes@fc04c000 {
>> @@ -698,7 +697,6 @@ tdes@fc04c000 {
>> dma-names = "tx", "rx";
>> clocks = <&pmc PMC_TYPE_PERIPHERAL 14>;
>> clock-names = "tdes_clk";
>> - status = "okay";
>> };
>>
>> sha@fc050000 {
>> @@ -710,7 +708,6 @@ sha@fc050000 {
>> dma-names = "tx";
>> clocks = <&pmc PMC_TYPE_PERIPHERAL 15>;
>> clock-names = "sha_clk";
>> - status = "okay";
>> };
>>
>> hsmc: smc@fc05c000 {
>> diff --git a/arch/arm/boot/dts/sama7g5.dtsi b/arch/arm/boot/dts/sama7g5.dtsi
>> index afd3e069b382..0b1e85541f7f 100644
>> --- a/arch/arm/boot/dts/sama7g5.dtsi
>> +++ b/arch/arm/boot/dts/sama7g5.dtsi
>> @@ -83,7 +83,6 @@ securam: securam@e0000000 {
>> #size-cells = <1>;
>> ranges = <0 0xe0000000 0x4000>;
>> no-memory-wc;
>> - status = "okay";
>> };
>>
>> secumod: secumod@e0004000 {
>> @@ -653,13 +652,11 @@ spi11: spi@400 {
>> uddrc: uddrc@e3800000 {
>> compatible = "microchip,sama7g5-uddrc";
>> reg = <0xe3800000 0x4000>;
>> - status = "okay";
>> };
>>
>> ddr3phy: ddr3phy@e3804000 {
>> compatible = "microchip,sama7g5-ddr3phy";
>> reg = <0xe3804000 0x1000>;
>> - status = "okay";
>> };
>>
>> gic: interrupt-controller@e8c11000 {
>> --
>> 2.32.0
>>
>>
>> _______________________________________________
>> linux-arm-kernel mailing list
>> linux-arm-kernel@xxxxxxxxxxxxxxxxxxx
>> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>
