On 05/02/2022 15:03, Michael Saunders wrote: > The Firefly RK3399 device tree had the GPU status set to disabled as per > the default from the rk3399.dtsi. This patch sets the status in the > firefly dts to enable it for use. I've tested this successfully on my > 2GB Firefly RK3399 board. > > Signed-off-by: Michael Saunders <mick.saunders@xxxxxxxxx> > --- > arch/arm64/boot/dts/rockchip/rk3399-firefly.dts | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/arch/arm64/boot/dts/rockchip/rk3399-firefly.dts b/arch/arm64/boot/dts/rockchip/rk3399-firefly.dts > index c4dd2a6b4836..f7b8da4953be 100644 > --- a/arch/arm64/boot/dts/rockchip/rk3399-firefly.dts > +++ b/arch/arm64/boot/dts/rockchip/rk3399-firefly.dts > @@ -298,6 +298,11 @@ &gmac { > status = "okay"; > }; > > +&gpu { > + mali-supply = <&vdd_gpu>; > + status = "okay"; Thanks for the patch. Please run scripts/checkpatch.pl, before sending it. You need to correct the indentation - just use the same as other places in the file. On your future submissions, please use scripts/get_maintainer.pl to get list of people and lists needed for CC. You missed here both rockchip and arm-kernel. Use "git log --oneline -- ..." to find the proper subject prefix for your subsystem and fix the subject. Best regards, Krzysztof