Hi Kuninori-san This patch series will break the old DTs, and I will follow Mark's Advice to maintain compatibility with the old DTs. I will send another version, please help me to review it. And I will also split the update patch series to many small ones. Thanks very much, BRs Xiubo > -----Original Message----- > From: Kuninori Morimoto [mailto:kuninori.morimoto.gx@xxxxxxxxx] > Sent: Monday, September 01, 2014 3:43 PM > To: Xiubo Li-B47053 > Cc: broonie@xxxxxxxxxx; lgirdwood@xxxxxxxxx; perex@xxxxxxxx; tiwai@xxxxxxx; > kuninori.morimoto.gx@xxxxxxxxxxx; moinejf@xxxxxxx; andrew@xxxxxxx; > jsarha@xxxxxx; devicetree@xxxxxxxxxxxxxxx; linux-arm- > kernel@xxxxxxxxxxxxxxxxxxx; linux-sh@xxxxxxxxxxxxxxx; alsa-devel@alsa- > project.org; Guo Shawn-R65073; Nicolin Chen; linux-kernel@xxxxxxxxxxxxxxx > Subject: Re: [alsa-devel] [PATCHv1 1/7] ASoC: simple-card: Merge single and > muti DAI link code. > > > Hi Xiubo > > Thank you for your patch. > This clean-up is very nice for me. > But, I have 1 small comment > > > asoc_simple_card_sub_parse_of(struct device_node *np, > > struct asoc_simple_dai *dai, > > struct device_node **p_node, > > - const char **name) > > + const char **name, > > + unsigned int *daifmt) > > { > > struct device_node *node; > > struct clk *clk; > > u32 val; > > int ret; > > > > + if (!daifmt) > > + return -EINVAL; > > + > > + /* > > + * Parse format, bitclock-inversion and frame-inversion > > + * for DAI each device. > > + */ > > + *daifmt = snd_soc_of_parse_daifmt(np, NULL, NULL, NULL); > > + *daifmt &= ~(SND_SOC_DAIFMT_MASTER_MASK | SND_SOC_DAIFMT_FORMAT_MASK); > (snip) > > ret = asoc_simple_card_sub_parse_of(np, &dai_props->cpu_dai, > > &dai_link->cpu_of_node, > > - &dai_link->cpu_dai_name); > > + &dai_link->cpu_dai_name, > > + &daifmt); > (snip) > > + dai_props->cpu_dai.fmt |= daifmt; > (snip) > > ret = asoc_simple_card_sub_parse_of(np, &dai_props->codec_dai, > > &dai_link->codec_of_node, > > - &dai_link->codec_dai_name); > > + &dai_link->codec_dai_name, > > + &daifmt); > (snip) > > + dai_props->codec_dai.fmt |= daifmt; > > These are using > > asoc_simple_card_sub_parse_of(np, &dai_props->cpu_dai, xxx) > asoc_simple_card_sub_parse_of(np, &dai_props->codec_dai, xxx) > > I guess, asoc_simple_card_sub_parse_of() can update > below inside function > > dai_props->cpu_dai.fmt |= daifmt; > dai_props->codec_dai.fmt |= daifmt; > > > Best regards > --- > Kuninori Morimoto -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
