On Fri, Feb 04, 2022 at 04:18:24AM -0800, Joe Perches wrote:
> On Fri, 2022-02-04 at 12:05 +0000, Russell King (Oracle) wrote:
> > On Wed, Feb 02, 2022 at 10:52:50AM -0600, nick.hawkins@xxxxxxx wrote:
> > > + if (readb_relaxed(timer->control) & MASK_TCS_TC) {
> > > + writeb_relaxed(MASK_TCS_TC, timer->control);
> > > +
> > > + event_handler = READ_ONCE(timer->evt.event_handler);
> > > + if (event_handler)
> > > + event_handler(&timer->evt);
> > > + return IRQ_HANDLED;
> > > + } else {
> > > + return IRQ_NONE;
> > > + }
> > > +}
>
> It's also less indented code and perhaps clearer to reverse the test
>
> if (!readb_relaxed(timer->control) & MASK_TCS_TC)
This will need to be:
if (!(readb_relaxed(timer->control) & MASK_TCS_TC))
> return IRQ_NONE;
>
> writeb_relaxed(MASK_TCS_TC, timer->control);
>
> event_handler = READ_ONCE(timer->evt.event_handler);
> if (event_handler)
> event_handler(&timer->evt);
>
> return IRQ_HANDLED;
>
>
>
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!
