On Wed, Feb 02, 2022 at 01:23:38PM -0800, Douglas Anderson wrote: > This patch makes a few improvements to the way that sdc1 / sdc2 > pinctrl is specified on sc7280: > > 1. There's no reason to "group" the sdc pins into one overarching node > and there's a downside: we have to replicate the hierarchy in the > board device tree files. Let's clean this up. > > 2. There's really not a lot of reason not to list the "pinctrl" for > sdc1 (eMMC) in the SoC dtsi file. These aren't GPIO pins and > everyone's going to specify the same pins. > > 3. Even though it's likely that boards will need to override pinctrl > for sdc2 (SD card) to add the card detect GPIO, we can be symmetric > and add it to the SoC dsti file. > > 4. Let's get rid of the word "on" from the normal config and add a > "sleep" suffix to the sleep config. This looks cleaner to me. > > This is intended to be a no-op change but it could plausibly change > behavior depending on how the pinctrl code parses things. One thing to > note is that "SD card detect" is explicitly listed now as keeping its > pull enabled in sleep since we still want to detect card insertions > even if the controller is suspended (because no card is inserted). The > pinctrl framework likely did this anyway, but it's nice to see it > explicit. Reviewed-by: Matthias Kaehlcke <mka@xxxxxxxxxxxx>
