On 26 August 2014 23:32, Hauke Mehrtens <hauke@xxxxxxxxxx> wrote: > On 08/25/2014 09:52 AM, Arnd Bergmann wrote: >> On Sunday 24 August 2014 23:24:41 Hauke Mehrtens wrote: >>> drivers/misc/Kconfig | 14 + >>> drivers/misc/Makefile | 1 + >>> drivers/misc/bcm47xx-sprom.c | 690 +++++++++++++++++++++ >> >> On a similar note, putting the driver into drivers/misc seems >> suboptimal: misc drivers should by definition be something that >> is for some odd hardware with no external dependencies on it, >> whereas your driver seems to be used by multiple other drivers. >> >> Would it make sense to put it into drivers/bcma when that is the >> only bus it is used on? > > As Jonas already said this code should be used for the bcm53xx ARM code > and the bcm47xx MIPS code and it is needed for drivers/bcma/ and > drivers/ssb/ (ssb only for old mips devices). Do you have any better > idea than putting this to drivers/misc/ ? For the mips SoC we need the > code very early and will not use the driver interface but probably > directly call the function name. Ping? Does anyone have any better idea? Both: nvram and sprom drivers will be used by bcm47xx (mips) and bcm53xx (arm). They can't be put in drivers/bcma, as they are used by drivers/ssb as well. -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html